Skip to content

chore: remove unused token meta schema and references #2676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore: remove unused token meta schema and references #2676

wants to merge 1 commit into from

Conversation

@thephez
Copy link
Collaborator

@thephez thephez commented Jun 19, 2025 •
edited by coderabbitai bot
Loading

Issue being fixed or feature implemented

Removes unused token meta schema to prevent confusion

What was done?

Deleted token-meta.json and removed references to it

How Has This Been Tested?

CI

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

Summary by CodeRabbit

  • Chores
    • Removed support for the token metadata schema, including its validation and related references.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 19, 2025 •
edited
Loading

Walkthrough

This change removes the token meta schema from the codebase. It deletes the JSON schema file, eliminates the associated constant and compiled schema, and removes all references to the token meta schema in the relevant Rust modules. No other logic or files are modified.

Changes

File(s) Change Summary
packages/rs-dpp/schema/meta_schemas/token/v0/token-meta.json Deleted the token meta JSON schema file.
packages/rs-dpp/src/data_contract/document_type/schema/enrich_with_base_schema/v0/mod.rs Removed the TOKEN_SCHEMA_URI_V0 constant.
packages/rs-dpp/src/validation/meta_validators/mod.rs Removed all references, static refs, and compiled schema related to the token meta schema.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant Codebase

    Developer->>Codebase: Remove token-meta.json schema file
    Developer->>Codebase: Delete TOKEN_SCHEMA_URI_V0 constant
    Developer->>Codebase: Remove TOKEN_META_JSON_V0 and TOKEN_META_SCHEMA_V0
    Note right of Codebase: All token meta schema references and definitions are now gone
Loading

Possibly related PRs

  • feat(dpp): token meta schema #2378: Removes the token meta schema JSON file and all related references, directly undoing the additions of the token meta schema and its compiled schema.

Suggested reviewers

  • QuantumExplorer

Poem

A schema once lived in the code,
For tokens, their rules well-owed.
But now it's gone, swept away,
No more meta here to stay.
The code is lighter, the path is clear,
Hippity-hop, no tokens here! 🐇

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bab21b3 and fe032c0.

📒 Files selected for processing (3)
  • packages/rs-dpp/schema/meta_schemas/token/v0/token-meta.json (0 hunks)
  • packages/rs-dpp/src/data_contract/document_type/schema/enrich_with_base_schema/v0/mod.rs (0 hunks)
  • packages/rs-dpp/src/validation/meta_validators/mod.rs (0 hunks)
💤 Files with no reviewable changes (3)
  • packages/rs-dpp/src/data_contract/document_type/schema/enrich_with_base_schema/v0/mod.rs
  • packages/rs-dpp/src/validation/meta_validators/mod.rs
  • packages/rs-dpp/schema/meta_schemas/token/v0/token-meta.json
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@thephez
Copy link
Collaborator Author

thephez commented Jun 19, 2025

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 19, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@thephez thephez marked this pull request as ready for review June 19, 2025 14:53
@thephez thephez requested a review from QuantumExplorer as a code owner June 19, 2025 14:53
@thephez thephez closed this Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuantumExplorer QuantumExplorer Awaiting requested review from QuantumExplorer QuantumExplorer is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@thephez